I was looking at something similar for the exact same use case.

Rather than adding a new hook, maybe we can use an argument to the current hook? It currently does not have any argument, so adding a new one should not cause any breakage.

Hi @renchap,

at first time I also tried to implement using one hook with an param. But I struggled with the types. Hopefully this new version is fitting better. But please evaluate the types. I have used as because I haven't any other idea how to solve it that typescript don't have any problems.

It should be cleaner to use Function Overloads like described here: https://www.typescriptlang.org/docs/handbook/2/functions.html#function-overloads

Something like:

function useBottomSheetInternal(): BottomSheetInternalContextType
function useBottomSheetInternal(unsafe: true): BottomSheetInternalContextType
export function useBottomSheetInternal(unsafe: false): BottomSheetInternalContextType | null {
  const context = useContext(BottomSheetInternalContext);

  if (unsafe !== true && context === null) {
    throw "'useBottomSheetInternal' cannot be used out of the BottomSheet!";
  }

  return context;
}

I did not test it but it should be the way to do it properly.

I have changed it to function overloading. should now be ready :)

@jembach @renchap I think this PR solves problem only partially. I have very similar issue when I try to use BottomSheetBackdrop component outside of <BottomSheetModal />.

BottomSheetBackdrop internally uses useBottomSheet hook

@likern I support your problem to be solved. But your problem is affecting much more code than i thought about and will definitely cause a breaking change accross the hole app.

One solution could be to create a new global Context that provides the information about if it could be accessed unsafe. The other solution would be that everything could return null and it must be handled every time.

At least i cannot really understand the use case when you render the backdrop without the BottomSheetModal.

I would suggest to create another PR to solve your problem.

@jembach My use-case is described in this issue #747. As soon as we use modal, we might have shared backdrop component, not tied to behaviour of one <BottomSheet />.

I just wanted to mention that this problem exists. I couldn't solve it easily, just will reimplement Backdrop from scratch.
I think generic and systematic solution would require redesign of library.

Hi @gorhom

how does it look to merge this request? I'll require it to solve some issues in our app.

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Hi @gorhom, could you spent a look on this PR

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

This would still be very useful!

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Still useful!

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Still useful :)

@jembach for submitting this pr!